trickle-ice: show url and relayProtocol if present #1561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fippo
commented
Jun 22, 2022
| let candidateStats; | ||
| if (['srflx', 'relay'].includes(candidate.type)) { | ||
| stats.forEach(report => { | ||
| if (!candidateStats && report.type === 'local-candidate' && report.address === candidate.address && report.port === candidate.port) { |
There was a problem hiding this comment.
I /think/ this sufficient to match the candidate
|
@henbos @alvestrand PTAL. The API inconsistency bothers me, I don't see a reason not to expose the same properties in onicecandidates as we do in stats. |
henbos
reviewed
Jun 27, 2022
note: this will work in M105+ once https://chromiumdash.appspot.com/commit/1fe14f2752a35932bea6d6ccff7433a6716c6391 is available
fippo
added a commit
to fippo/webrtc
that referenced
this pull request
Aug 16, 2022
alternative implementation of webrtc#1561
alvestrand
reviewed
Oct 17, 2022
| const stats = await pc.getStats(); | ||
| stats.forEach(report => { | ||
| if (!candidateStats && report.type === 'local-candidate' && report.address === candidate.address && report.port === candidate.port) { | ||
| candidateStats = report; |
There was a problem hiding this comment.
should there be a 'break' here, or is there some fear that we'll want to match the last one not the first one?
There was a problem hiding this comment.
you can't break a .forEach :-(
alvestrand
approved these changes
Oct 17, 2022
|
relayProtocol is polyfilled in Chrome/Safari in adapter-latest.js as of yesterday! |
|
changed to actually have a built-in expiry date so the getStats call no longer happens when url is there |
fippo
added a commit
to fippo/webrtc
that referenced
this pull request
Oct 28, 2022
since some of the current information is not relevant for this use-case and revert the width of the table which was enlarged in webrtc#1561 since this is no longer necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: this will work in M105+ once
https://chromiumdash.appspot.com/commit/1fe14f2752a35932bea6d6ccff7433a6716c6391
is available