feat: enable tree-shaking for ESM external modules with named imports #19641
+648
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ernal-module-render
Verify that the implementation generates named imports for better tree-shaking
CodSpeed Performance ReportMerging #19641 will degrade performances by 94.11%Comparing Summary
Benchmarks breakdown
|
c6e4dd3 to
7a37133
Compare
5514a63 to
39ee0a6
Compare
|
@alexander-akait I tried a few different yarn fix commands but couldn't get the lint CI to pass. Could you help fix this? (Might need to update snapshots too, maybe?) |
|
@3ru You can run |
eeebd81 to
39ee0a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes the implementation started in #19416, resolving the InitFragment handling issue that was blocking the original work. The main problem was that external modules were not generating proper named imports when using module concatenation, instead falling back to namespace imports.
What kind of change does this PR introduce?
Feature completion - This change enable tree-shaking optimization for external ESM modules in the
ModuleConcatenationPluginby:1. InitFragment Collection in ModuleConcatenationPlugin
InitFragmentsfrom external modules during code generationchunkInitFragmentsfor correct import statement generation2. External Module Analysis in
_analyseModuleexportMapandrawExportMapbased ongetUsedExports()resultsexternalType === "module"and outputting ES modules3. ConcatenationScope Integration
Did you add tests for your changes?
Yes, added the
modern-module-tree-shaking-simpletest case that:Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?