feat: enable ESM worker chunk loading for Node.js targets #19640
+244
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #19640 will degrade performances by 94.1%Comparing Summary
Benchmarks breakdown
|
e02f9f7 to
e4f1117
Compare
|
Memo: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
adds basic ESM worker support for Node.js targets.
What this PR enables:
new Worker(url, { type: "module" })workerChunkLoading: "import"configuration works whenoutput.chunkFormatis "module"import ... from ...) work inside workersCurrent limitations:
await import()) inside workers do not yet split into separate chunksRel: #17121
Did you add tests for your changes?
Yes, added:
test/Defaults.unittest.jsto verify correct defaults generationtest/configCases/worker/node-worker-esm/to verify runtime behaviornpx jest test/Defaults.unittest.js -t "target node with ESM output" --updateSnapshotDoes this PR introduce a breaking change?
This change affects configurations that explicitly use ESM output (
experiments.outputModule: true) with Node.js targets.