Skip to content

fix: fix occasional error thrown by module.size() #19637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fix occasional error thrown by module.size() #19637

wants to merge 1 commit into from

Conversation

xiaoxiaojx
Copy link
Member

What kind of change does this PR introduce?

fixes TypeError: Cannot read properties of undefined (reading 'getSize')

Did you add tests for your changes?

Yes

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

No

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 28, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #19637 will degrade performances by 94.24%

Comparing fix/module_size (43146db) with main (5bcd259)

Summary

⚡ 3 improvements
❌ 2 regressions
✅ 128 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ benchmark "future-defaults", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 49.5 ms 11.7 ms ×4.2
⚡ benchmark "many-chunks-commonjs", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 62 ms 10 ms ×6.2
❌ benchmark "minimal", scenario '{"name":"mode-development","mode":"development"}' 24.2 ms 30.6 ms -20.91%
⚡ benchmark "react", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 35.1 ms 11.1 ms ×3.2
❌ benchmark "three-long", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 13.2 ms 229.2 ms -94.24%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xiaoxiaojx