Skip to content

refactor: replace the implementation of magic_number #19636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: replace the implementation of magic_number #19636

wants to merge 1 commit into from

Conversation

xiaoxiaojx
Copy link
Member

What kind of change does this PR introduce?
refactoring

Did you add tests for your changes?
No

Does this PR introduce a breaking change?
No

What needs to be documented once your changes are merged?
No

@xiaoxiaojx xiaoxiaojx force-pushed the refactor/del_magic_number branch from a5d4fb9 to 45b2693 Compare June 28, 2025 09:51
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 28, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #19636 will degrade performances by 94.17%

Comparing refactor/del_magic_number (45b2693) with main (5bcd259)

Summary

⚡ 7 improvements
❌ 86 regressions
✅ 40 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ benchmark "devtool-eval", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 42.3 ms 11.7 ms ×3.6
⚡ benchmark "devtool-eval-source-map", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 39.3 ms 11.4 ms ×3.5
❌ benchmark "devtool-source-map", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 10.4 ms 42.8 ms -75.72%
⚡ benchmark "future-defaults", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 49.5 ms 11.7 ms ×4.2
⚡ benchmark "lodash", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 34.7 ms 11.4 ms ×3
⚡ benchmark "many-chunks-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 62.3 ms 10.7 ms ×5.8
⚡ benchmark "many-modules-commonjs", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 53 ms 9.9 ms ×5.3
⚡ benchmark "many-modules-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 47.5 ms 11.2 ms ×4.2
❌ benchmark "three-long", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 13.2 ms 226.5 ms -94.17%
❌ md4 buffer benchmark (size: 10000) 72.8 µs 117.2 µs -37.91%
❌ md4 buffer benchmark (size: 100000) 406.4 µs 493.6 µs -17.66%
❌ md4 buffer benchmark (size: 120) 34.7 µs 76.2 µs -54.54%
❌ md4 buffer benchmark (size: 160) 34.7 µs 76.4 µs -54.52%
❌ md4 buffer benchmark (size: 16366) 97.1 µs 141.5 µs -31.36%
❌ md4 buffer benchmark (size: 16368) 97.2 µs 141.6 µs -31.35%
❌ md4 buffer benchmark (size: 16370) 97.2 µs 141.5 µs -31.31%
❌ md4 buffer benchmark (size: 2) 34.8 µs 76.3 µs -54.32%
❌ md4 buffer benchmark (size: 20) 32.4 µs 76.2 µs -57.48%
❌ md4 buffer benchmark (size: 200) 35 µs 79.4 µs -55.95%
❌ md4 buffer benchmark (size: 2000) 40.6 µs 84.9 µs -52.23%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xiaoxiaojx