Skip to content

perf: remove useless startupEntrypoint for ESM #19627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

perf: remove useless startupEntrypoint for ESM #19627

merged 1 commit into from
Jun 26, 2025

Conversation

xiaoxiaojx
Copy link
Member

What kind of change does this PR introduce?
perf: EntryStartup has been replaced by this commit because it does not support ESM scenarios.

Did you add tests for your changes?
No

Does this PR introduce a breaking change?
No

What needs to be documented once your changes are merged?
No

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 25, 2025

CodSpeed Performance Report

Merging #19627 will degrade performances by 78.37%

Comparing perf/esm-chunk-format (74ff82d) with main (10fb556)

Summary

⚡ 4 improvements
❌ 81 regressions
✅ 48 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ benchmark "devtool-eval", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 37.4 ms 44.6 ms -16.15%
⚡ benchmark "devtool-source-map", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 42.7 ms 11.6 ms ×3.7
⚡ benchmark "future-defaults", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 47.7 ms 11.7 ms ×4.1
⚡ benchmark "lodash", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 34.9 ms 10.2 ms ×3.4
❌ benchmark "many-modules-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 11.2 ms 51.7 ms -78.37%
⚡ benchmark "minimal", scenario '{"name":"mode-development","mode":"development"}' 30.6 ms 24.3 ms +25.64%
❌ benchmark "react", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 10.8 ms 35.9 ms -69.79%
❌ md4 buffer benchmark (size: 10000) 72.8 µs 114.3 µs -36.31%
❌ md4 buffer benchmark (size: 120) 34.6 µs 76.1 µs -54.51%
❌ md4 buffer benchmark (size: 160) 34.7 µs 76.2 µs -54.41%
❌ md4 buffer benchmark (size: 16366) 97.1 µs 138.6 µs -29.9%
❌ md4 buffer benchmark (size: 16368) 97.2 µs 138.6 µs -29.89%
❌ md4 buffer benchmark (size: 16370) 97.2 µs 138.8 µs -29.98%
❌ md4 buffer benchmark (size: 2) 34.7 µs 76.5 µs -54.61%
❌ md4 buffer benchmark (size: 20) 32.2 µs 76.4 µs -57.82%
❌ md4 buffer benchmark (size: 200) 34.9 µs 76.4 µs -54.27%
❌ md4 buffer benchmark (size: 2000) 40.5 µs 82.1 µs -50.64%
❌ md4 buffer benchmark (size: 20000) 111.4 µs 152.8 µs -27.12%
❌ md4 buffer benchmark (size: 2002) 40.5 µs 81.9 µs -50.57%
❌ md4 buffer benchmark (size: 40) 32.2 µs 73.7 µs -56.28%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@alexander-akait alexander-akait merged commit fab6c68 into main Jun 26, 2025
41 of 44 checks passed
@alexander-akait alexander-akait deleted the perf/esm-chunk-format branch June 26, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaoxiaojx @alexander-akait