Skip to content

use nonNumericOnlyHash function for contentHash #15289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2022
Merged

use nonNumericOnlyHash function for contentHash #15289

merged 2 commits into from
Feb 3, 2022

Conversation

vankop
Copy link
Member

@vankop vankop commented Feb 1, 2022

What kind of change does this PR introduce?

fixes #15288

Did you add tests for your changes?

partial

Does this PR introduce a breaking change?

no

What needs to be documented once your changes are merged?

nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@vankop vankop force-pushed the disallow-digest-only-content-hash branch from a6dbd6a to f1d329c Compare February 1, 2022 17:11
sokra
sokra requested changes Feb 2, 2022
View reviewed changes
@sokra sokra removed their assignment Feb 2, 2022
@webpack-bot
Copy link
Contributor

@vankop Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

@sokra sokra merged commit f2d99d8 into main Feb 3, 2022
@sokra
Copy link
Member

sokra commented Feb 3, 2022

Thanks

@sokra sokra deleted the disallow-digest-only-content-hash branch February 3, 2022 08:22
@vankop vankop mentioned this pull request Mar 2, 2022
Closed
@makaria makaria mentioned this pull request Dec 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees

@sokra sokra

Labels
PR: reviewed-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

invalid key when chunks are formatted with non-zero only
3 participants
@vankop @webpack-bot @sokra