add missing fields to candidate stats #611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvestrand
reviewed
Nov 8, 2021
|
@dontcallmedom can you generate an IPR link please and take a look at the respec woes? Worked with 27 here, breaks with 28 now. Probably need to blow some dust off ;-) |
|
Makes sense |
|
actually the inconsistency is a bit bigger: https://w3c.github.io/webrtc-stats/#icecandidate-dict* I don't have a use-case for the missing candidate stats (apart from making the grid in webrtc-internals nicer) but knowing the relayProtocol and url of a gathered candidate is potentially useful (see e.g. here) Will update this after testing how hard that is to implement |
|
aha... url is apparently surfaced in onicecandidate: |
|
bump |
alvestrand
approved these changes
Sep 27, 2022
as as defined as in [webrtc-pc](https://w3c.github.io/webrtc-pc/#dom-rtcicecandidate-tcptype) Not terribly important but i wanted it to show a nice candidate grid from statistics
henbos
approved these changes
Oct 4, 2022
ibaoger
pushed a commit
to ibaoger/webrtc
that referenced
this pull request
Oct 4, 2022
added in w3c/webrtc-stats#611 * foundation * relatedAddress * relatedPort * usernameFragment * tcpType BUG=webrtc:14480 Change-Id: I5f43373fbbc7c780b8dafb6e2ace2c27f5e22970 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276780 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Philipp Hancke <[email protected]> Reviewed-by: Henrik Boström <[email protected]> Cr-Commit-Position: refs/heads/main@{#38292}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 15, 2023
Upstream commit: https://webrtc.googlesource.com/src/+/0e3cd63062007d7c67e70eac7a45f29964d9c9aa stats: add missing ice candidate stats added in w3c/webrtc-stats#611 * foundation * relatedAddress * relatedPort * usernameFragment * tcpType BUG=webrtc:14480 Change-Id: I5f43373fbbc7c780b8dafb6e2ace2c27f5e22970 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276780 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Philipp Hancke <[email protected]> Reviewed-by: Henrik Boström <[email protected]> Cr-Commit-Position: refs/heads/main@{#38292}
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Feb 20, 2023
Upstream commit: https://webrtc.googlesource.com/src/+/0e3cd63062007d7c67e70eac7a45f29964d9c9aa stats: add missing ice candidate stats added in w3c/webrtc-stats#611 * foundation * relatedAddress * relatedPort * usernameFragment * tcpType BUG=webrtc:14480 Change-Id: I5f43373fbbc7c780b8dafb6e2ace2c27f5e22970 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276780 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Philipp Hancke <[email protected]> Reviewed-by: Henrik Boström <[email protected]> Cr-Commit-Position: refs/heads/main@{#38292}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all of which are already defined for the ICE candidate object itself
Preview | Diff
Preview | Diff