Skip to content

Namespace module ids with package.json name. Resolves #1767. #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 122 commits into from

Conversation

jolyndenning
Copy link

See #1767 for explanation. I'm looking forward to any feedback on a better way to get the package.json name, or a better namespace to use entirely rather than the package.json name.

haoqunjiang and others added 25 commits November 5, 2020 16:51
Otherwise the emitted type definitions may break downstream users who do
not have these options enabled.

Thanks @meteorlxy for spotting this issue.
- new `<script setup>` vuejs/rfcs#227
- new `<style>` variable injection vuejs/rfcs#231

Requires a version of `@vue/compiler-sfc` that supports the above features.

Also should fix vuejs#1723
…uejs#1764)

This option provides a solution for vuejs#1734

When testing with mocha + mochapack, even though the target
environment is `node`, the compiled component is expected to be run
with `jsdom` rather than with a Node.js server, so it should still be
a client bundle.
This fixes the css var injection having different id from generated CSS
@jolyndenning
Copy link
Author

I created this pull request to the wrong branch, and my code was also branched off of master instead of next. That's why the diff got so weird here. Github is not letting me change the base branch of this pull request anymore, so I will create a new PR for this.

@jolyndenning
Copy link
Author

I've created #1769 which has the correct base branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.