-
Notifications
You must be signed in to change notification settings - Fork 918
Namespace module ids with package.json name. Resolves #1767. #1768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the emitted type definitions may break downstream users who do not have these options enabled. Thanks @meteorlxy for spotting this issue.
- new `<script setup>` vuejs/rfcs#227 - new `<style>` variable injection vuejs/rfcs#231 Requires a version of `@vue/compiler-sfc` that supports the above features. Also should fix vuejs#1723
…uejs#1764) This option provides a solution for vuejs#1734 When testing with mocha + mochapack, even though the target environment is `node`, the compiled component is expected to be run with `jsdom` rather than with a Node.js server, so it should still be a client bundle.
This fixes the css var injection having different id from generated CSS
73927bd
to
66deee0
Compare
I created this pull request to the wrong branch, and my code was also branched off of master instead of |
I've created #1769 which has the correct base branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1767 for explanation. I'm looking forward to any feedback on a better way to get the package.json name, or a better namespace to use entirely rather than the package.json name.