-
-
Notifications
You must be signed in to change notification settings - Fork 685
chore: Use ESLint v9 in development env #2775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: ab84a13 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@2nofa11 Once this PR is merged, please rebase your PR 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Flo Edelmann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, thank you! Apart from two questions (which don't necessarily need to be resolved in context of this PR), this looks good to me.
I think this PR fixes #2756, right? So maybe @2nofa11 you want to have a look, too?
I’d love to take a look!
I’m still getting up to speed with the codebase, so I might have some beginner-level questions 😭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now. Thank you! 🙂
This PR will change the development environment to use ESLint v9.
After looking into the documentation build errors in #2770, I found that a lot of changes are needed.
I want to address those issues first with this PR.
Also, some tests were failing for the script-indent rule when using typescript-eslint v8, so I fixed those as well.