Skip to content

feat(no-deprecated-slot-attribute): regex ignore patterns #2773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 1, 2025
Merged

feat(no-deprecated-slot-attribute): regex ignore patterns #2773

merged 9 commits into from
Jul 1, 2025
+108 −6

Conversation

ST-DDT
Copy link
Contributor

@ST-DDT ST-DDT commented Jun 28, 2025 •
edited
Loading

Partially fixes #2710

Adds support for '/regex/' ignore patterns.

    <template>
      <LinkList>
        <one slot="one" />
        <two slot="two" />
        <my-component slot="my-component-slot" />
        <myComponent slot="myComponent-slot" />
        <MyComponent slot="MyComponent-slot" />
      </LinkList>
    </template>
{
  ignore: ['/one/', '/^Two$/i', '/^my-.*/i']
}

Implementation based on #2734

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 9d44658

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-vue Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ST-DDT ST-DDT mentioned this pull request Jun 28, 2025
Open
2 tasks
@ST-DDT ST-DDT marked this pull request as ready for review June 28, 2025 20:10
@ST-DDT
Copy link
Contributor Author

ST-DDT commented Jun 28, 2025

Tested with production code, kind of works as expected, with the limitations lined out here:

waynzh
waynzh requested changes Jul 1, 2025
View reviewed changes
Copy link
Member

@waynzh waynzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!
One small suggestion on tests.

waynzh
waynzh approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@waynzh waynzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@waynzh waynzh requested a review from FloEdelmann July 1, 2025 08:22
FloEdelmann
FloEdelmann requested changes Jul 1, 2025
View reviewed changes
waynzh
waynzh reviewed Jul 1, 2025
View reviewed changes
waynzh
waynzh reviewed Jul 1, 2025
View reviewed changes
FloEdelmann
FloEdelmann reviewed Jul 1, 2025
View reviewed changes
FloEdelmann
FloEdelmann approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thank you 🙂

@FloEdelmann FloEdelmann merged commit fb4c1c0 into vuejs:master Jul 1, 2025
11 checks passed
@github-actions github-actions bot mentioned this pull request Jun 10, 2025
Draft
@ST-DDT ST-DDT deleted the issue-2710/no-deprecated-slot-attribute/regex-ignore branch July 1, 2025 15:49
@ST-DDT ST-DDT mentioned this pull request Jul 1, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynzh waynzh waynzh approved these changes

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vue/no-deprecated-slot-attribute conflicts with web component named slots
3 participants
@ST-DDT @FloEdelmann @waynzh