Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should cues be ordered? #2235

Open
dmlap opened this issue Jun 5, 2015 · 3 comments
Open

Should cues be ordered? #2235

dmlap opened this issue Jun 5, 2015 · 3 comments
Labels
confirmed enhancement pinned Things that stalebot shouldn't close automatically

Comments

@dmlap
Copy link
Member

dmlap commented Jun 5, 2015 •
edited by gkatsev
Loading

My reading of the spec implies that cues should time-ordered when accessed through their text track. It appears cues are in insertion-order in Chrome on OS X.
@heff
Copy link
Member

heff commented Jun 5, 2015

Best ask @RickEyre about that one.

Why are the orders different?

@gkatsev
Copy link
Member

gkatsev commented Nov 17, 2015

We probably should, though, seems like most VTT files are structures correctly and insertion order is the same as timed order. I'm guessing this could make a difference for rendering because each cue gets rendered above/below (couldn't really figure this out from the vtt spec) the previous cue. This particularly matters if you have multiple cues with the same starting and ending times.

@gkatsev
Copy link
Member

gkatsev commented Nov 17, 2015

Marking it as an enhancement. If we have time (or someone PRs it), we should do it. Otherwise, what we have is Good Enough™.

@gkatsev gkatsev added the pinned Things that stalebot shouldn't close automatically label Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed enhancement pinned Things that stalebot shouldn't close automatically
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@heff @dmlap @gkatsev