Skip to content

fix(eslint-plugin): remove allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing option #9923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

developer-bandi
Copy link
Contributor

PR Checklist

Overview

remove rule's option, test case using option, docs option description

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @developer-bandi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 7991def
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66d8636fb275090008bf1ec2
😎 Deploy Preview https://deploy-preview-9923--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94 (🔴 down 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Sep 3, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7991def. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.03%. Comparing base (6f24fe6) to head (7991def).
Report is 212 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9923      +/-   ##
==========================================
- Coverage   88.12%   86.03%   -2.09%     
==========================================
  Files         406      425      +19     
  Lines       13951    14790     +839     
  Branches     4076     4299     +223     
==========================================
+ Hits        12294    12725     +431     
- Misses       1344     1718     +374     
- Partials      313      347      +34     
Flag Coverage Δ
unittest 86.03% <100.00%> (-2.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...slint-plugin/src/rules/no-unnecessary-condition.ts 98.55% <100.00%> (-0.01%) ⬇️
...lint-plugin/src/rules/prefer-nullish-coalescing.ts 100.00% <100.00%> (ø)
...int-plugin/src/rules/strict-boolean-expressions.ts 100.00% <100.00%> (ø)

... and 26 files with indirect coverage changes

@kirkwaiblinger kirkwaiblinger added DO NOT MERGE PRs which should not be merged yet breaking change This change will require a new major version to be released labels Sep 8, 2024
@kirkwaiblinger
Copy link
Member

Hi @developer-bandi! Thanks for sending this in. This will be a breaking change for v9, so I'm marking this as a draft for now until we're ready to create a v9 branch. We'll pick this back up then! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This change will require a new major version to be released bug Something isn't working DO NOT MERGE PRs which should not be merged yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Remove allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing
3 participants