Skip to content

chore: make copy-ast-spec non cacheable #11367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025
Merged

Conversation

JamesHenry
Copy link
Member

@JamesHenry JamesHenry commented Jul 1, 2025

The types:copy-ast-spec task could hit the remote cache when the ast-spec build outputs were changing. This change ensures that is now impossible by making it so that copy-ast-spec will always run. It's a very cheap operation anyway.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JamesHenry!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jul 1, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit a9f20e1
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/6863e2d495f5b20008e815db
😎 Deploy Preview https://deploy-preview-11367--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 77 (🔴 down 21 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

nx-cloud bot commented Jul 1, 2025

View your CI Pipeline Execution ↗ for commit a9f20e1.

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 55s View ↗
nx run-many -t lint ✅ Succeeded 2m 2s View ↗
nx run-many -t typecheck ✅ Succeeded 1m 59s View ↗
nx run generate-configs ✅ Succeeded 6s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 9s View ↗
nx run integration-tests:test ✅ Succeeded 6s View ↗
nx run types:build ✅ Succeeded 5s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-07-01 13:42:19 UTC

@JamesHenry JamesHenry changed the title chore: add ast-spec dist to test:copy-ast-spec inputs chore: make copy-ast-spec non cacheable Jul 1, 2025
@JamesHenry JamesHenry force-pushed the copy-ast-spec-inputs branch from 66e73eb to a9f20e1 Compare July 1, 2025 13:29
@JamesHenry JamesHenry marked this pull request as ready for review July 1, 2025 13:42
@JamesHenry JamesHenry merged commit 5b378e2 into main Jul 1, 2025
63 checks passed
@JamesHenry JamesHenry deleted the copy-ast-spec-inputs branch July 1, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant