Skip to content

feat(utils): support basePath property in type Config of ESLint #11363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(utils): support basePath property in type Config of ESLint #11363

wants to merge 1 commit into from
+7 −0

Conversation

ntnyq
Copy link
Contributor

@ntnyq ntnyq commented Jul 1, 2025

PR Checklist

Overview

This PR adds basePath property to type Config of ESLint.

Partial of #11356 since #11357 does not do this.

@Copilot Copilot AI review requested due to automatic review settings July 1, 2025 09:52
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ntnyq!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jul 1, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit f20c43b
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/6863afe650e1240008bb3dd9
😎 Deploy Preview https://deploy-preview-11363--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 93 (🔴 down 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot
Copilot AI reviewed Jul 1, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces the optional basePath property to the ESLint Config type, allowing configuration file patterns (files and ignores) to be interpreted relative to a specific directory.

  • Added basePath property with inline documentation in the Config interface.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 1, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit f20c43b.

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m View ↗
nx run-many -t typecheck ✅ Succeeded 2m 6s View ↗
nx run-many -t lint ✅ Succeeded 2m 2s View ↗
nx run integration-tests:test ✅ Succeeded 4s View ↗
nx run types:build ✅ Succeeded 1s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 1s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 8s View ↗
nx run generate-configs ✅ Succeeded 4s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-07-01 10:05:12 UTC

@bradzacher
Copy link
Member

Thanks for the PR but there is already a PR up for this:
#11357

@bradzacher bradzacher closed this Jul 1, 2025
@ntnyq
Copy link
Contributor Author

ntnyq commented Jul 1, 2025

Thanks for the PR but there is already a PR up for this: #11357

#11357 only changes package typescript-eslint and adds basePath support for tseslint.config().

This PR changes the package utils and support basePath property in type Config.

It's not the same.

@kirkwaiblinger
Copy link
Member

@ntnyq would you mind commenting with what's missing in #11357? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Support basePath property in Config of ESLint
3 participants
@ntnyq @bradzacher @kirkwaiblinger