Skip to content

fix(eslint-plugin): [no-deprecated] should report deprecated exports and reexports #11359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(eslint-plugin): [no-deprecated] should report deprecated exports and reexports #11359

wants to merge 2 commits into from
+73 −4

Conversation

mainframev
Copy link

@mainframev mainframev commented Jun 30, 2025 •
edited
Loading

PR Checklist

Overview

  • Removed skipping of export statements from isInsideExportOrImport guard function and renamed it to isInsideImport to skip only imports.
  • Updated the test file with export / reexports cases

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @mainframev!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jun 30, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 451857f
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/6863aa6250e1240008dcb3a4
😎 Deploy Preview https://deploy-preview-11359--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 30, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 451857f.

Command Status Duration Result
nx run-many -t lint ❌ Failed 2m 6s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 4m 59s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 4s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 3s View ↗
nx run integration-tests:test ✅ Succeeded 4s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 1s View ↗
nx run generate-configs ✅ Succeeded 9s View ↗
nx run types:build ✅ Succeeded 1s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-07-01 09:40:38 UTC

@mainframev mainframev changed the title fix(eslint-plugin)[no-deprecated]: should report deprecated exports and reexports fix(eslint-plugin):[no-deprecated] should report deprecated exports and reexports Jun 30, 2025
@mainframev mainframev changed the title fix(eslint-plugin):[no-deprecated] should report deprecated exports and reexports fix(eslint-plugin): [no-deprecated] should report deprecated exports and reexports Jun 30, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.84%. Comparing base (e2ecca6) to head (451857f).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11359   +/-   ##
=======================================
  Coverage   90.84%   90.84%           
=======================================
  Files         501      501           
  Lines       50919    50924    +5     
  Branches     8387     8389    +2     
=======================================
+ Hits        46256    46261    +5     
  Misses       4648     4648           
  Partials       15       15
Flag Coverage Δ
unittest 90.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/eslint-plugin/src/rules/no-deprecated.ts 97.00% <100.00%> (+0.04%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mainframev mainframev force-pushed the fix/no-deprecated-rule-support-exports-reexports branch from 51cabaf to dd8869b Compare June 30, 2025 18:47
@mainframev mainframev mentioned this pull request Jun 30, 2025
Draft
@mainframev mainframev marked this pull request as ready for review June 30, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-deprecated] doesn't work on export/re-export statements
1 participant
@mainframev