Skip to content

fix(typescript-estree): ensure the token type of the property name is Identifier #11329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(typescript-estree): ensure the token type of the property name is Identifier #11329

wants to merge 2 commits into from
+0 −19

Conversation

ntdiary
Copy link
Contributor

@ntdiary ntdiary commented Jun 22, 2025

PR Checklist

Overview

I've gone with option 1 in the comments for now, if any regressions come up later, we can discuss them or try the other option if needed. :)

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ntdiary!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jun 22, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit fa670da
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/685b705e557eba0008ade520
😎 Deploy Preview https://deploy-preview-11329--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🟢 up 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 22, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit fa670da.

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 4m 50s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 7s View ↗
nx run types:build ✅ Succeeded 1s View ↗
nx run-many -t typecheck ✅ Succeeded 1m 54s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 19s View ↗
nx run-many -t lint ✅ Succeeded 10s View ↗
nx run integration-tests:test ✅ Succeeded <1s View ↗
nx run generate-configs ✅ Succeeded 5s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-06-25 03:53:45 UTC

@codecov Codecov
Copy link

codecov bot commented Jun 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.85%. Comparing base (9dc91aa) to head (fa670da).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11329      +/-   ##
==========================================
+ Coverage   90.84%   90.85%   +0.01%     
==========================================
  Files         501      501              
  Lines       50919    50901      -18     
  Branches     8387     8381       -6     
==========================================
- Hits        46256    46246      -10     
+ Misses       4648     4641       -7     
+ Partials       15       14       -1
Flag Coverage Δ
unittest 90.85% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/typescript-estree/src/node-utils.ts 63.04% <ø> (+0.21%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ntdiary ntdiary marked this pull request as ready for review June 25, 2025 05:23
JoshuaKGoldberg
JoshuaKGoldberg requested changes Jun 30, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer to @bradzacher for the nuances of parsing. But in the meantime this change should have unit tests. We don't yet test things like a.if and a.yield. They'll have to be added here too. Thanks!

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
awaiting response Issues waiting for a reply from the OP or another party
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: The token type of if in the 262 IdentifierName production should be Identifier instead of Keyword
2 participants
@ntdiary @JoshuaKGoldberg