Skip to content

fix(typescript-estree): infers singleRun as true for project service #11327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix(typescript-estree): infers singleRun as true for project service #11327

wants to merge 7 commits into from
+9 −1

Conversation

nayounsang
Copy link
Contributor

PR Checklist

Overview

As project is null when projectService is true, we have to fix validate logic

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @nayounsang!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jun 21, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit fd15f0c
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/6863e62a868846000822c5b4
😎 Deploy Preview https://deploy-preview-11327--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 77 (🔴 down 21 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 21, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit fd15f0c.

Command Status Duration Result
nx test typescript-estree --coverage=false ❌ Failed 24s View ↗
nx run-many -t typecheck ❌ Failed 2m 5s View ↗
nx test typescript-estree ❌ Failed 32s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 12s View ↗
nx run types:build ✅ Succeeded 6s View ↗
nx run integration-tests:test ✅ Succeeded 6s View ↗
nx run generate-configs ✅ Succeeded 6s View ↗
nx run-many --target=build --parallel --exclude... ✅ Succeeded 9s View ↗
Additional runs (4) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-07-01 13:50:16 UTC

@nayounsang nayounsang marked this pull request as draft June 21, 2025 11:14
@nayounsang
Copy link
Contributor Author

Why tests was failed in CI?
In my local, there was no problem.

@nayounsang
Copy link
Contributor Author

nayounsang commented Jun 23, 2025 •
edited
Loading

Can't reproduce test errors in local development.
In test, parseSettings.singleRun from packages/typescript-estree/src/parser.ts/parseAndGenerateServices is false.
So, it doesn't seem to be related to this commit.
I verified that the test results and (of course) the singleRun results did not change before and after the commit.
This work only affects singleRun.

@nayounsang nayounsang marked this pull request as ready for review June 23, 2025 08:07
JoshuaKGoldberg
JoshuaKGoldberg reviewed Jun 30, 2025
View reviewed changes
packages/typescript-estree/src/parseSettings/inferSingleRun.ts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😕 I also don't reproduce the failures locally. Even when running completely outside of Nx:

yarn
cd packages/typescript-estree
TYPESCRIPT_ESLINT_PROJECT_SERVICE=true yarn vitest tests/lib/parse.test.ts

This might be a question for @JamesHenry. Maybe some other cache shenanigans are in play?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finalized the general nx config follow ups PR and merged it into here, hopefully that helps, otherwise I'll look more specifically at this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesHenry JamesHenry JamesHenry left review comments

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug(typescript-estree): never infers singleRun as true for project service
3 participants
@nayounsang @JamesHenry @JoshuaKGoldberg