Skip to content

chore: migrate to pnpm #11248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 85 commits into
base: main
Choose a base branch
from

Conversation

xaos7991
Copy link
Contributor

@xaos7991 xaos7991 commented May 27, 2025

PR Checklist

Overview

xaos7991 and others added 30 commits May 18, 2025 21:32
refactor: removed .yarn folder

fix: changed overrides approach

feat: changed references
Migrate scripts to pnpm and replaced yarn reference
Resolved problems with babel types
docs: updated comments to reflect pnpm usage instead of yarn
@JoshuaKGoldberg
Copy link
Member

@xaos7991 thanks for sending this PR & working on it! I'm really excited about it 🎉. Since it's still got some merge conflicts & seems to be under active development, I'm going to switch it to draft (otherwise it'll keep coming up on my to-review-now queue). Whenever you're ready, go ahead and un-draft it -> we can take a look. Or holler if you need anything. 🙂

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft June 9, 2025 11:32
# Conflicts:
#	packages/ast-spec/package.json
#	yarn.lock
@xaos7991 xaos7991 marked this pull request as ready for review June 9, 2025 11:49
@xaos7991
Copy link
Contributor Author

xaos7991 commented Jun 9, 2025

@xaos7991 thanks for sending this PR & working on it! I'm really excited about it 🎉. Since it's still got some merge conflicts & seems to be under active development, I'm going to switch it to draft (otherwise it'll keep coming up on my to-review-now queue). Whenever you're ready, go ahead and un-draft it -> we can take a look. Or holler if you need anything. 🙂

Hi! Thanks again for switching the PR to draft — that was a good call.

I’ve resolved the latest merge conflicts, and the PR is ready for review again.
Since the main branch is quite active, new merges tend to cause conflicts on my side — but I’m doing my best to keep up and fix them as soon as possible.

Let me know if anything else is needed!

@JoshuaKGoldberg
Copy link
Member

Great! In that case, if the issue is just that main introduces conflicts, I think it's fine to not merge in until review. I don't want our in-and-out availability to cause you a lot of extra work. Thanks for the note 🙂

xaos7991 and others added 8 commits June 9, 2025 20:51
# Conflicts:
#	packages/eslint-plugin/package.json
#	packages/type-utils/package.json
#	yarn.lock
# Conflicts:
#	package.json
#	packages/eslint-plugin/package.json
#	packages/type-utils/package.json
#	packages/website/package.json
#	yarn.lock
fix: resolved conflicts

fix: corrected the version
xaos7991 and others added 6 commits June 28, 2025 09:17
# Conflicts:
#	CONTRIBUTORS.md
#	packages/eslint-plugin/package.json
#	packages/type-utils/package.json
#	tools/scripts/generate-contributors.mts
#	yarn.lock
# Conflicts:
#	packages/eslint-plugin/package.json
#	packages/type-utils/package.json
#	yarn.lock
# Conflicts:
#	knip.ts
#	nx.json
#	packages/ast-spec/package.json
#	packages/eslint-plugin-internal/package.json
#	packages/eslint-plugin/package.json
#	packages/integration-tests/package.json
#	packages/parser/package.json
#	packages/rule-schema-to-typescript-types/package.json
#	packages/rule-tester/package.json
#	packages/scope-manager/package.json
#	packages/type-utils/package.json
#	packages/types/package.json
#	packages/typescript-eslint/package.json
#	packages/typescript-estree/package.json
#	packages/utils/package.json
#	packages/visitor-keys/package.json
#	yarn.lock
@xaos7991
Copy link
Contributor Author

xaos7991 commented Jul 1, 2025

Hi @JoshuaKGoldberg, @JamesHenry, @bradzacher, @kirkwaiblinger, and the rest of the team! 👋

First of all, thank you for all the work you do maintaining this project — it’s a huge help to the community, and I really appreciate the time and care you put into it.

I was just wondering if there’s any chance a maintainer could take a look at this PR. I understand you're all busy, but since it hasn’t received a review from a maintainer yet, I’d be happy, along with @Jester175, to revise or adjust anything needed once there’s some feedback.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo: Migrate from yarn to pnpm
5 participants