Skip to content

chore: fix issues introduced by updated nx configuration #11230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jul 1, 2025
Merged

chore: fix issues introduced by updated nx configuration #11230

merged 18 commits into from
Jul 1, 2025
+393 −302

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented May 21, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 612f34c
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/6863a4c8b1e3ce000838c870
😎 Deploy Preview https://deploy-preview-11230--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 97 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 21, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 612f34c.

Command Status Duration Result
nx run-many -t typecheck ✅ Succeeded 2m 7s View ↗
nx run-many -t lint ✅ Succeeded 2m 4s View ↗
nx run integration-tests:test ✅ Succeeded 47s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 3s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 1s View ↗
nx run types:build ✅ Succeeded 1s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 1s View ↗
nx run generate-configs ✅ Succeeded 4s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-07-01 09:10:51 UTC

@codecov Codecov
Copy link

codecov bot commented May 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.84%. Comparing base (f9bd7d8) to head (612f34c).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11230   +/-   ##
=======================================
  Coverage   90.84%   90.84%           
=======================================
  Files         501      501           
  Lines       50919    50919           
  Branches     8387     8387           
=======================================
  Hits        46256    46256           
  Misses       4648     4648           
  Partials       15       15
Flag Coverage Δ
unittest 90.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kirkwaiblinger
Copy link
Member

Hi @aryaemami59 Are you still working on this and/or is it ready for review?

@aryaemami59 aryaemami59 marked this pull request as ready for review June 24, 2025 14:58
JamesHenry
JamesHenry previously approved these changes Jul 1, 2025
View reviewed changes
@aryaemami59 aryaemami59 force-pushed the chore/fix-nx-config-issues branch from ac57f06 to 3a2efe0 Compare July 1, 2025 08:27
@JamesHenry
Copy link
Member

@aryaemami59 I'm working on this

@JamesHenry
Copy link
Member

@aryaemami59 Please don't push anymore

@JamesHenry JamesHenry merged commit e2ecca6 into typescript-eslint:main Jul 1, 2025
65 checks passed
@aryaemami59 aryaemami59 deleted the chore/fix-nx-config-issues branch July 1, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesHenry JamesHenry JamesHenry left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: address issues introduced by updated nx configuration
3 participants
@aryaemami59 @kirkwaiblinger @JamesHenry