Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the new thin mode in Ior #10922

Open
1 of 18 tasks
savaleonard opened this issue Jun 10, 2024 · 0 comments
Open
1 of 18 tasks

Add support for the new thin mode in Ior #10922

savaleonard opened this issue Jun 10, 2024 · 0 comments

Comments

@savaleonard
Copy link

Feature Description

TypeOrm does not support connecting to Oracle in thin mode. To enable this connection mode, a walletPassword must be provided. However, the current Oracle driver does not support this argument.

  • [ ]

The Solution

add a new propertie to OracleConnectionCredentialsOptions type called walletPassword of type string
in the file OracleDriver.js , method OracleDriver.createPool replace

 const connectionOptions = Object.assign({}, {
            user: credentials.username,
            password: credentials.password,
            connectString: credentials.connectString,
        }, {
            poolMax: options.poolSize,
        }, options.extra || {})

with

 const connectionOptions = Object.assign({}, {
            user: credentials.username,
            password: credentials.password,
            connectString: credentials.connectString,
           walletPassword: credentials.walletPassword
        }, {
            poolMax: options.poolSize,
        }, options.extra || {})

Considered Alternatives

the solution is described above

Additional Context

I have the fix as mentioned above, but the test setup is not working properly for me .

Relevant Database Driver(s)

  • aurora-mysql
  • aurora-postgres
  • better-sqlite3
  • cockroachdb
  • cordova
  • expo
  • mongodb
  • mysql
  • nativescript
  • oracle
  • postgres
  • react-native
  • sap
  • spanner
  • sqlite
  • sqlite-abstract
  • sqljs
  • sqlserver

Are you willing to resolve this issue by submitting a Pull Request?

Yes, I have the time, and I know how to start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant