Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

knot_weights function expects only a int (but not a tensor) as a parameter #707

Open
TMS-Namespace opened this issue Dec 2, 2022 · 0 comments
Open

knot_weights function expects only a int (but not a tensor) as a parameter #707

TMS-Namespace opened this issue Dec 2, 2022 · 0 comments

Comments

@TMS-Namespace
Copy link

TMS-Namespace commented Dec 2, 2022 •
edited
Loading

The knot_weights function, from:
tensorflow_graphics.math.interpolation.bspline
requires an int for the number of knots and the degree parameters (it is mentioned in the documentation), and if a tf.constant is passed, the unhashable tensor exception will occur.

Although it is not really a bug, this seems to be a design flaw, and not expected at all (especially that other parameters are expecting tensors), since it breaks graph generation with @tf.function, unless I will convert it explicitly to int, as pointed here: tensorflow/tensorflow#27491 (comment)
@TMS-Namespace TMS-Namespace changed the title knot_weights function requires a numpy int (but not a tensor) as a parameter knot_weights function requires a numpy int (but not a tensor) as a parameter Dec 2, 2022
@TMS-Namespace TMS-Namespace changed the title knot_weights function requires a numpy int (but not a tensor) as a parameter knot_weights function expects only a numpy int (but not a tensor) as a parameter Dec 2, 2022
@TMS-Namespace TMS-Namespace changed the title knot_weights function expects only a numpy int (but not a tensor) as a parameter knot_weights function expects only a int (but not a tensor) as a parameter Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TMS-Namespace