Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance issue in the definition of render_splat, tensorflow_graphics/rendering/tests/splat_test.py #642

Open
DLPerf opened this issue Aug 19, 2021 · 1 comment
Open

Performance issue in the definition of render_splat, tensorflow_graphics/rendering/tests/splat_test.py #642

DLPerf opened this issue Aug 19, 2021 · 1 comment

Comments

@DLPerf
Copy link

DLPerf commented Aug 19, 2021

Hello, I found a performance issue in the definition of render_splat, tensorflow_graphics/rendering/tests/splat_test.py, tf.reduce_mean in line 160 and 162 will be calculated repeatedly during program execution. I think it should be created before the loop in render_splat.

The same issue exist in tf.gather.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.
@fcole
Copy link
Contributor

fcole commented Aug 30, 2021

Hi there, I'm not sure I follow where the issue is in this test. A PR to fix it would help clarify, for sure!

@DLPerf DLPerf mentioned this issue Sep 2, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fcole @DLPerf