[Security] Remove deprecated RememberMeToken::getSecret() and RememberMeToken's $secret property
#61011
+10
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RememberMeToken::getSecret() and RememberMeToken's $secret property
OskarStark
reviewed
Jul 1, 2025
src/Symfony/Component/Security/Core/Authentication/Token/RememberMeToken.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Jul 1, 2025
| public function __serialize(): array | ||
| { | ||
| // $this->firewallName should be kept at index 1 for compatibility with payloads generated before Symfony 8 | ||
| return [$this->secret, $this->firewallName, parent::__serialize()]; | ||
| // Newly serialized data removes the secret deprecated since Symfony 7.2 and removed in Symfony 8.0 |
There was a problem hiding this comment.
You mean the comment ? or the method ?
002f9c9 to
63e71e7
Compare
RememberMeToken::getSecret() and RememberMeToken's $secret propertyRememberMeToken::getSecret() and RememberMeToken's $secret property
alexandre-daubois
approved these changes
Jul 2, 2025
welcoMattic
reviewed
Jul 4, 2025
| } | ||
|
|
||
| public function __unserialize(array $data): void | ||
| { | ||
| [$this->secret, $this->firewallName, $parentData] = $data; | ||
| // BC Layer with payloads generated before Symfony 8.0 |
There was a problem hiding this comment.
Suggested change
| // BC Layer with payloads generated before Symfony 8.0 | |
| // BC Layer with payloads generated before Symfony 8.0, to be removed in Symfony 9.0 |
Is it ok to keep such a BC Layer here? @OskarStark @stof
xabbuh
requested changes
Jul 6, 2025
In which way ? I've removed the deprecation notice there : https://github.com/symfony/symfony/pull/61011/files#diff-8cdcb3fe63f51aca31c4a5869e39ffdfcc793d9d855df4498528a56e1bbd32cdL35-L39. Is there something I missed updating this ? |
|
@ktherage That's the token, but there also is an authenticator class. |
…erMeToken's secret property
…ions are triggered
…berMeToken.php Co-authored-by: Oskar Stark <[email protected]>
799ce91 to
9767a2a
Compare
|
@xabbuh I did it and rebased. Sorry for this forgetfulness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.