Skip to content

[Workflow] Remove deprecated Event::getWorkflow() #60989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2025
Merged

[Workflow] Remove deprecated Event::getWorkflow() #60989

merged 1 commit into from
Jul 4, 2025
+145 −12

Conversation

mttsch
Copy link
Contributor

@mttsch mttsch commented Jun 30, 2025

Q A
Branch? 8.0
Bug fix? no
New feature? yes
Deprecations? no
Issues
License MIT

@mttsch mttsch requested a review from lyrixx as a code owner June 30, 2025 17:53
@carsonbot carsonbot added this to the 8.0 milestone Jun 30, 2025
@mttsch
Copy link
Contributor Author

mttsch commented Jun 30, 2025

Symfony docs do not need update, also see symfony/symfony-docs#20883.

UPGRADE before/after is based on deprecation version from version 7.3.

OskarStark
OskarStark reviewed Jun 30, 2025
View reviewed changes
OskarStark
OskarStark reviewed Jun 30, 2025
View reviewed changes
OskarStark
OskarStark reviewed Jun 30, 2025
View reviewed changes
@mttsch mttsch force-pushed the feature/workflow_event_depreaction branch from 1254bd8 to 4257733 Compare July 1, 2025 03:25
@mttsch
Copy link
Contributor Author

mttsch commented Jul 1, 2025

@OskarStark I used a slightly different formatting to keep in sync with the existing ones in the file, also see 26bc5b3.

xabbuh
xabbuh reviewed Jul 1, 2025
View reviewed changes
@mttsch mttsch force-pushed the feature/workflow_event_depreaction branch from 4257733 to 3d14ed9 Compare July 1, 2025 10:37
@alexandre-daubois alexandre-daubois requested a review from xabbuh July 2, 2025 08:21
@welcoMattic welcoMattic added the BC Layer removal Used to track BC layer removals before a major release label Jul 4, 2025
@welcoMattic
Copy link
Member

Thank you @mttsch.

@welcoMattic welcoMattic merged commit 9f4d2b9 into symfony:8.0 Jul 4, 2025
8 of 10 checks passed
@mttsch mttsch deleted the feature/workflow_event_depreaction branch July 4, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx approved these changes

@OskarStark OskarStark OskarStark approved these changes

@alexandre-daubois alexandre-daubois alexandre-daubois approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
BC Layer removal Used to track BC layer removals before a major release Feature Status: Needs Review Workflow
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
7 participants
@mttsch @welcoMattic @lyrixx @OskarStark @xabbuh @alexandre-daubois @carsonbot