Skip to content

[Form] Fix precision loss when rounding large integers in NumberToLocalizedStringTransformer #60975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 6.4
Choose a base branch
from
Open

[Form] Fix precision loss when rounding large integers in NumberToLocalizedStringTransformer #60975

wants to merge 1 commit into from
+33 −0

Conversation

OskarStark
Copy link
Contributor

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #60947
License MIT

@carsonbot carsonbot added this to the 6.4 milestone Jun 30, 2025
@carsonbot carsonbot changed the title Fix precision loss when rounding large integers in NumberToLocalizedStringTransformer [Form] Fix precision loss when rounding large integers in NumberToLocalizedStringTransformer Jun 30, 2025
@OskarStark
Fix precision loss when rounding large integers in `NumberToLocalized…
bf312d3 
…StringTransformer`

Add type check in `round()` method to bypass rounding for integer values,
preventing precision loss for large integers that are still below PHP_INT_MAX.

🤖 Generated with [Claude Code](https://claude.ai/code)
@OskarStark OskarStark force-pushed the fix-number-transformer-precision-6.4 branch from dca4cfb to bf312d3 Compare July 1, 2025 18:07
@OskarStark
Copy link
Contributor Author

Failure looks unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhbailly mhbailly mhbailly left review comments

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
Form
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
3 participants
@OskarStark @mhbailly @carsonbot