Skip to content

[Form] Remove BC layer from ResizeFormListener #60952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2025
Merged

[Form] Remove BC layer from ResizeFormListener #60952

merged 1 commit into from
Jul 2, 2025
+8 −109

Conversation

OskarStark
Copy link
Contributor

Q A
Branch? 8.0
Bug fix? no
New feature? no
Deprecations? no
Issues --
License MIT

@carsonbot carsonbot added this to the 8.0 milestone Jun 29, 2025
@OskarStark OskarStark force-pushed the remove-resizeformlistener-bc-layer branch from 54b564b to 237d06d Compare June 30, 2025 06:43
xabbuh
xabbuh requested changes Jun 30, 2025
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testPreSetDataResizesForm() test also needs to be removed (I wonder why the tests don't fail)

@OskarStark
Copy link
Contributor Author

The testPreSetDataResizesForm() test also needs to be removed (I wonder why the tests don't fail)

Done

@OskarStark OskarStark force-pushed the remove-resizeformlistener-bc-layer branch from 237d06d to 45281ac Compare June 30, 2025 07:02
@xabbuh
Copy link
Member

xabbuh commented Jun 30, 2025

The "Verify Packages" failure also looks related. :)

@OskarStark OskarStark force-pushed the remove-resizeformlistener-bc-layer branch from 45281ac to f8ddd36 Compare June 30, 2025 07:43
@OskarStark
Copy link
Contributor Author

The "Verify Packages" failure also looks related. :)

Indeed, done, thanks

@OskarStark OskarStark requested a review from xabbuh June 30, 2025 07:44
@OskarStark OskarStark mentioned this pull request Jul 1, 2025
Closed
@OskarStark OskarStark force-pushed the remove-resizeformlistener-bc-layer branch from f8ddd36 to 4afda18 Compare July 1, 2025 09:11
OskarStark
OskarStark commented Jul 1, 2025
View reviewed changes
@OskarStark
Copy link
Contributor Author

Rebased

@fabpot fabpot force-pushed the remove-resizeformlistener-bc-layer branch from 5f042bf to 1812cfa Compare July 2, 2025 19:04
@fabpot
Copy link
Member

fabpot commented Jul 2, 2025

Thank you @OskarStark.

@fabpot fabpot merged commit 06e4c90 into symfony:8.0 Jul 2, 2025
8 of 9 checks passed
@fabpot fabpot mentioned this pull request Jul 3, 2025
Closed
@welcoMattic welcoMattic added the BC Layer removal Used to track BC layer removals before a major release label Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@stof stof stof approved these changes

@yceruto yceruto yceruto approved these changes

@alexandre-daubois alexandre-daubois alexandre-daubois approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
BC Layer removal Used to track BC layer removals before a major release Form Status: Reviewed
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
8 participants
@OskarStark @xabbuh @fabpot @stof @yceruto @alexandre-daubois @welcoMattic @carsonbot