[String] Leverage grapheme_str_split() #60887
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Jun 24, 2025
| Q | A |
|---|---|
| Branch? | 7.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | - |
| License | MIT |
GromNaN
reviewed
Jun 24, 2025
| @@ -751,7 +751,7 @@ public static function provideReverse() | |||
| [ | |||
| ['äuß⭐erst', 'tsre⭐ßuä'], | |||
| ['漢字ーユニコードéèΣσς', 'ςσΣèéドーコニユー字漢'], | |||
| ['नमस्ते', 'तेस्मन'], | |||
| // ['नमस्ते', 'तेस्मन'], this case requires a version of intl that supports Unicode 15.1 | |||
There was a problem hiding this comment.
If this test case previously passed and no longer passes with the change you are making, isn't that a regression that could affect users?
There was a problem hiding this comment.
yes it is, but that's only for exotic scripts, which can be managed fine with a recent enough version of ICU (which is likely a requirement anyway when dealing with such scripts)
alexandre-daubois
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.