Skip to content

[Validator] Add missing HasNamedArguments to some constraints #60840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

jkgroupe
Copy link
Contributor

@jkgroupe jkgroupe commented Jun 19, 2025

Q A
Branch? 7.3
Bug fix? no
New feature? no
Deprecations? yes
Issues Fix #60838
License MIT

Add missing HasNamedArguments attribute on __construct(...) to fix symfony 7.4 deprecation

@jkgroupe jkgroupe marked this pull request as ready for review June 19, 2025 14:25
@carsonbot carsonbot added this to the 7.4 milestone Jun 19, 2025
@symfony symfony deleted a comment from carsonbot Jun 19, 2025
@nicolas-grekas
Copy link
Member

AtLeastOneOf has the same issue?

@jkgroupe jkgroupe changed the title [Validator] [Constraints] [Image] Add missing HasNamedArguments to fix symfony 7.4 deprecation [Validator] [Constraints] Add missing HasNamedArguments to fix symfony 7.4 deprecation Jun 19, 2025
@jkgroupe
Copy link
Contributor Author

jkgroupe commented Jun 19, 2025

AtLeastOneOf has the same issue?

Yes. I add it to this PR

@xabbuh xabbuh modified the milestones: 7.4, 7.3 Jun 19, 2025
@nicolas-grekas nicolas-grekas modified the milestones: 7.3, 6.4 Jun 20, 2025
@nicolas-grekas nicolas-grekas changed the title [Validator] [Constraints] Add missing HasNamedArguments to fix symfony 7.4 deprecation [Validator] Add missing HasNamedArguments to Image and AtLeastOneOf constraints Jun 20, 2025
@nicolas-grekas nicolas-grekas modified the milestones: 6.4, 7.3 Jun 20, 2025
@nicolas-grekas nicolas-grekas changed the base branch from 7.4 to 7.3 June 20, 2025 16:13
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I rebased for 7.3)

Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do Composite, Compound, GroupSequence and Sequentially also need the same update?

Edit: And also the UserPassword constraint from the Security component.

@nicolas-grekas nicolas-grekas changed the title [Validator] Add missing HasNamedArguments to Image and AtLeastOneOf constraints [Validator] Add missing HasNamedArguments to some constraints Jun 23, 2025
@nicolas-grekas
Copy link
Member

Thank you @jkgroupe.

@nicolas-grekas nicolas-grekas merged commit 1714f71 into symfony:7.3 Jun 23, 2025
9 of 11 checks passed
@fabpot fabpot mentioned this pull request Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Validator] Symfony\Component\Validator\Constraints\Image not supporting named arguments is deprecated
4 participants