[Validator] deprecate handling options in the base Constraint class #60801
+673
−179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jun 16, 2025
| Q | A |
|---|---|
| Branch? | 7.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | yes |
| Issues | Fix #60029 |
| License | MIT |
stof
reviewed
Jun 16, 2025
src/Symfony/Component/Validator/Attribute/InitializesOptions.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Tests/Constraints/AtLeastOneOfValidatorTest.php
Outdated
Show resolved
Hide resolved
e6f87d8 to
b08f6af
Compare
stof
reviewed
Jun 20, 2025
9bdaa28 to
fe67424
Compare
|
I think this is now ready. I have also added some more details to the changelog/upgrade files to explain how to update custom constraints around the several deprecations. |
OskarStark
reviewed
Jun 21, 2025
stof
reviewed
Jun 27, 2025
OskarStark
reviewed
Jul 3, 2025
UPGRADE-7.4.md
Outdated
Comment on lines
49
to
50
| Before: | ||
|
|
There was a problem hiding this comment.
Suggested change
| Before: | |
| **Before** |
that's how we use it in the 8.0 upgrade file, not a blocker
OskarStark
approved these changes
Jul 3, 2025
fabpot
reviewed
Jul 6, 2025
| class CustomConstraint extends Constraint | ||
| { | ||
| public $option1; | ||
| public $option2; |
There was a problem hiding this comment.
They are because these properties are populated by the parent normalizeOptions() method if I don't misunderstand what you mean (basically the statement $knownOptions = get_class_vars(static::class); is built on top of the existence of the properties).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.