[HttpKernel] Fix #[MapUploadedFile] handling for optional file uploads
#60483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santysisi
commented
May 19, 2025
...ony/Component/HttpKernel/Tests/Controller/ArgumentResolver/UploadedFileValueResolverTest.php
Outdated
Show resolved
Hide resolved
|
It seems that the error reported by Psalm was resolved in version 7.3. What should I do in cases like this? 🤔 |
5f9bda8 to
10e5189
Compare
10e5189 to
90948a3
Compare
|
You can ignore the psalm error for now |
90948a3 to
65cd406
Compare
65cd406 to
fba1f45
Compare
|
Hi 👋 Just checking in, Are there any issues or changes needed for this PR? 🙂 Also, the pipeline errors seem unrelated to the changes in this PR. Thanks! |
|
Thank you @santysisi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug with the
#[MapUploadedFile]attribute in routes, where an optional ?UploadedFile parameter does not behave as expected when no file is provided.