Skip to content

chore: move stuff from analysis into global compiler state #16268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 30, 2025

Conversation

Rich-Harris
Copy link
Member

per #16255 (comment), this scratches an itch I've had for a while: we put a lot of stuff on context.state.analysis that doesn't really form part of the analysis phase, it's just a convenient place to stick it.

It would be more convenient if that stuff was part of the global state exported from state.js — just as we guard dev-only compiler logic in if (dev) rather than if (context.state.analysis.dev) we could also do if (runes), for example.

While doing this I realised that we don't need to do state.reset inside parse(...), because we only actually need to reset source and locator. This means parse no longer needs to take an unused filename option, so we can remove this in Svelte 6 and make that API simpler.

This PR doesn't replace all the occurrences of context.state.analysis.runes (and .name, etc) because that would likely create merge conflicts. That can be done as an easy follow-up when there's less stuff in the PR queue.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jun 30, 2025

⚠️ No Changeset found

Latest commit: 7fc6240

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot
Copy link

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16268

@dummdidumm
Copy link
Member

dummdidumm commented Jun 30, 2025

This is cool - let's just hope our compiler never needs to become async 😜

@Rich-Harris
Copy link
Member Author

if it does, AsyncLocalStorage to the rescue!

@dummdidumm dummdidumm merged commit eb530c8 into main Jun 30, 2025
14 checks passed
@dummdidumm dummdidumm deleted the global-analysis-state branch June 30, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants