chore: move stuff from analysis
into global compiler state
#16268
+57
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per #16255 (comment), this scratches an itch I've had for a while: we put a lot of stuff on
context.state.analysis
that doesn't really form part of the analysis phase, it's just a convenient place to stick it.It would be more convenient if that stuff was part of the global state exported from
state.js
— just as we guard dev-only compiler logic inif (dev)
rather thanif (context.state.analysis.dev)
we could also doif (runes)
, for example.While doing this I realised that we don't need to do
state.reset
insideparse(...)
, because we only actually need to resetsource
andlocator
. This meansparse
no longer needs to take an unusedfilename
option, so we can remove this in Svelte 6 and make that API simpler.This PR doesn't replace all the occurrences of
context.state.analysis.runes
(and.name
, etc) because that would likely create merge conflicts. That can be done as an easy follow-up when there's less stuff in the PR queue.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint