Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16114
When a
$state
or a$derived
is directly set by the user, we properly add it to theold_values
Map
.However when a derived is updated as a result of the
check_dirtiness
check duringflush_queued_effects
, we do not save the old value, hence the value read in a teardown function of a$effect
is not the old value but the new one, this is incosistent with the "old value behavior" that was recently introduced.In this PR i save the old value when the
$derived
is updated, so that it will be used by teardown functions of$effect
s.However while working on this i've noticed that there's an edge case when working with child components.
While passing a prop in certain conditions (either a legacy bindable or a prop accessed via
$.prop
because it has a setter somewhere in the code) the original$state
is wrapped in aderived
. When the child component is destroyed the teardown functions might read$.prop
values that did not got update because thay were not read (perhaps in the template). This means that is possible that during the execution of the teardown the values of the derived are eithernull
because they were never initialized because nothing ever read from it, or they are outdated. I've opened a separate issue for this: #16262.This bug is present both before and after the changes of this PR.
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint