Skip to content

lint - openai client protocol #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
Merged

lint - openai client protocol #87

merged 1 commit into from
May 23, 2025

Conversation

pgrayy
Copy link
Member

@pgrayy pgrayy commented May 23, 2025

Description

Fixing lint error (see results).

One call out, hatch run lint was passing locally before this change, but we saw failures on GitHub action execution. Will follow up to figure out the discrepancy. Could be a difference in dependency versions installed into our local venvs vs GitHub action venvs.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

  • hatch fmt --linter
  • hatch fmt --formatter
  • hatch test --all
  • Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

Checklist

  • I have read the CONTRIBUTING document
  • I have added tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pgrayy pgrayy requested a review from a team as a code owner May 23, 2025 16:04
@pgrayy pgrayy merged commit 0bb2b64 into strands-agents:main May 23, 2025
10 of 20 checks passed
@pgrayy pgrayy deleted the lint branch May 27, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants