fix(telemetry): correct environment variable precedence for OTEL config #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zastrowm
requested changes
May 23, 2025
|
Tested locally with constructor, env. Export as designed. |
zastrowm
previously approved these changes
May 27, 2025
zastrowm
approved these changes
May 27, 2025
Unshure
approved these changes
May 28, 2025
jer96
pushed a commit
to lukehau/sdk-python
that referenced
this pull request
Jun 3, 2025
…ig (strands-agents#86) * fix(telemetry): correct environment variable precedence for OTEL configuration * fix(telemetry): update get_tracer function to adapt the changes * fix(telemetry): fix tracer initialization --------- Co-authored-by: Jack Yuan <[email protected]>
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Provide a detailed description of the changes in this PR]
Correct environment variable precedence for OTEL config
Related Issues
[Link to related issues using #issue-number format]
Documentation PR
[Link to related associated PR in the agent-docs repo]
Type of Change
x Bug fix
[Choose one of the above types of changes]
Testing
[How have you tested the change?]
Local test and local deploy, test otel behavior then validate via Langfuse.
hatch fmt --linterhatch fmt --formatterhatch test --allChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.