Add ensure_ascii=False to json.dumps() calls in telemetry tracer #37
Conversation
There was a problem hiding this comment.
Thank you for the awesome PR @moritalous, really appreciate your contributions.
Can we add unit test coverage to https://github.com/strands-agents/sdk-python/blob/main/tests/strands/telemetry/test_tracer.py to guarantee that the characters are not escaped so that we don't regress on this in the future?
It might perhaps be nice, and make it easier to write a unit test case for, to have a function in https://github.com/strands-agents/sdk-python/blob/main/src/strands/telemetry/tracer.py (serialize() ?) that is called instead of calling json.dumps directly throughout the file. This new function could call json.dumps in one place, setting both ensure_ascii=False and cls=JSONEncoder.
…ASCII character handling
|
@awsarron |
|
Thank you for your contribution @moritalous ❤️ We'll get this deployed in the next patch version of strands-agents. |
Description
This PR adds ensure_ascii=False parameter to all json.dumps() calls in the telemetry tracer module. This change ensures proper handling of non-ASCII characters (such as Japanese, Chinese, or emoji) in telemetry data by preventing them from being escaped as \uXXXX sequences in JSON output. The modification improves readability of logs and telemetry data when working with international content.
Related Issues
No specific issue ticket, addressing as part of internationalization improvements.
Documentation PR
N/A - This is an internal implementation change that doesn't require documentation updates.
Type of Change
Testing
• [x] hatch fmt --linter
• [x] hatch fmt --formatter
• [x] hatch test --all
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.