Skip to content

chore: update spanKind and attributes for tokens #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

poshinchen
Copy link
Contributor

@poshinchen poshinchen commented Jun 26, 2025

Description

  1. Update the SpanKind following the conventions.
  • Mark model_invoke span and start_agent span with SpanKind: CLIENT
  • Mark event_loop, tool_call, default to SpanKind.INTERNAL
  1. Add first simple semantic conventions on metrics related data
  • This will unblock genesis team about the mappings.

Documentation PR

Will update trace attributes after all semantic conventions are merged.

Type of Change

Other (please describe):

  • trace span small update

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • [] I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@poshinchen poshinchen requested a review from a team June 26, 2025 19:38
@poshinchen poshinchen marked this pull request as ready for review June 26, 2025 19:42
@poshinchen poshinchen force-pushed the chore/update-spans-spankind branch from 4f2d6b4 to 6fecdce Compare June 27, 2025 14:25
@poshinchen poshinchen changed the title chore: update spanKind chore: update spanKind and token semantic conventions Jun 27, 2025
@poshinchen poshinchen changed the title chore: update spanKind and token semantic conventions chore: update spanKind and attributes for tokens Jun 27, 2025
@poshinchen poshinchen merged commit 7f41d79 into strands-agents:main Jun 27, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants