-
Notifications
You must be signed in to change notification settings - Fork 183
chore: refactor tracer #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
poshinchen
merged 1 commit into
strands-agents:main
from
poshinchen:chore/exporters-configurations
Jun 26, 2025
Merged
chore: refactor tracer #286
poshinchen
merged 1 commit into
strands-agents:main
from
poshinchen:chore/exporters-configurations
Jun 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jer96
requested changes
Jun 25, 2025
272df02
to
e1ddae0
Compare
e1ddae0
to
9383776
Compare
changes are moving in a great direction, thank you! a couple notes:
|
jer96
reviewed
Jun 25, 2025
ea9d066
to
d953141
Compare
d953141
to
f854585
Compare
jer96
approved these changes
Jun 26, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We faced dependency conflict before. In order to prevent the issues happening again and allow users to configure exporters, this pr refactors the tracer and created StrandsTelemetry class for configurations.
Current behavior:
Expected Behaviors after the change:
STRANDS_OTEL_ENABLE_CONSOLE_EXPORT
If user sets up the tracer already by themselves, using Agent will directly picks up the tracer (without any other envs set)
Example:
If user wants Strands-Agent to setup tracer
All default choices (from Opentelemtry):
Via Environment variables
Related Issues
Will link them
Documentation PR
Will update the documentation
Type of Change
Testing
hatch run prepare
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.