Writer model provider #228
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awsarron
requested changes
Jun 25, 2025
src/strands/models/palmyra.py
Outdated
| "totalTokens": event["data"].total_tokens, | ||
| }, | ||
| "metrics": { | ||
| "latencyMs": 0, # All palmyra models don't provide 'latency' metadata |
There was a problem hiding this comment.
could this be a feature request for Writer teams to return server-side latency data?
There was a problem hiding this comment.
I'll check with the API team on this
There was a problem hiding this comment.
@awsarron it's not currently on the roadmap. I'll talk it through with Product and Eng but even if so it likely wouldn't be in time for this launch/deadline.
|
would be worth opening a PR for Writer model provider documentation in https://github.com/strands-agents/docs. https://strandsagents.com/latest/user-guide/concepts/model-providers/llamaapi/ can be used as an example. It would be good to follow the same style, formatting, and language for consistency. |
awsarron
requested changes
Jun 26, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of Writer LLMs provider
Related Issues
#227
Documentation PR
N/A
Type of Change
Testing
Integration and Unit test of created implementation
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.