Skip to content

fix: remove unused dependency swagger-parser #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

zastrowm
Copy link
Member

Description

Having the dependency breaks uv installs as swagger-parser depends on pre-release library which is not allowed by default

As far as I can tell, this dependency is not used anywhere and can be safely removed

Details

Before these changes:

 uv sync --extra dev
  × No solution found when resolving dependencies:
  ╰─▶ Because there is no version of pyyaml==5.2b1 and swagger-parser==1.0.2 depends on pyyaml==5.2b1, we can conclude that swagger-parser==1.0.2 cannot be used.
      And because only swagger-parser<=1.0.2 is available, we can conclude that swagger-parser>=1.0.2 cannot be used.
      And because strands-agents[dev] depends on swagger-parser>=1.0.2 and your project requires strands-agents[dev], we can conclude that your project's requirements are unsatisfiable.

      hint: `pyyaml` was requested with a pre-release marker (e.g., pyyaml==5.2b1), but pre-releases weren't enabled (try: `--prerelease=allow`)

After these changes:

uv sync --extra dev
Resolved 147 packages in 957ms
      Built strands-agents @ file:///Users/zastrowm/workspace/strands/sdk-python
Prepared 16 packages in 10.75s
Installed 99 packages in 226ms
 + annotated-types==0.7.0
 + anyio==4.9.0
 + argcomplete==3.6.2
...

Related Issues

N/A

Documentation PR

N/A

Type of Change

Bug fix

Testing

  • hatch fmt --linter
  • hatch fmt --formatter
  • hatch test --all
  • Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

Checklist

  • I have read the CONTRIBUTING document
  • I have added tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Having the dependency breaks uv installs as swagger-parser depends on pre-release library which is not allowed by default

As far as I can tell, this dependency is not used anywhere and can be safely removed
Copy link
Member

@Unshure Unshure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this may have been included by accident as part of some OpenAPI -> Tool feature at some point. Makes sense to remvoe

@zastrowm zastrowm merged commit 4dd0819 into strands-agents:main Jun 17, 2025
10 checks passed
pgrayy pushed a commit to pgrayy/sdk-python that referenced this pull request Jun 18, 2025
Having the dependency breaks uv installs as swagger-parser depends on pre-release library which is not allowed by default

As far as I can tell, this dependency is not used anywhere and can be safely removed

Co-authored-by: Mackenzie Zastrow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants