Skip to content

fix: add inference profile to litellm test and remove ownership check… #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dbschmigelski
Copy link
Member

Description

Follow up to #201 .

It seems there were two bugs.

One was that the the inference profile seems to need to be added. Unclear why this worked locally earlier, but that is not important.

The other is that for the enterprise organization it seems that the ownership check is not needed. For now, we will simply require the approved for integ test label We can attempt to optimize if the collaborators find this provides too much friction.

Related Issues

#201

Type of Change

  • Bug fix

Testing

[How have you tested the change?]

  • hatch fmt --linter
  • hatch fmt --formatter
  • hatch test --all
  • Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

Tested tests-integ/test_model_litellm.py

========================================================================= 1 passed, 54 warnings in 13.73s ==========================================================================

Checklist

  • I have read the CONTRIBUTING document
  • I have added tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dbschmigelski dbschmigelski added the approved-for-integ-test Indicator that a pull request has been approved to run integration tests label Jun 12, 2025
@dbschmigelski dbschmigelski merged commit 7c5f7a7 into strands-agents:main Jun 12, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-for-integ-test Indicator that a pull request has been approved to run integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants