chore(deps): relax docstring_parser version to allow 0.16 #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbschmigelski
requested changes
Jun 11, 2025
| @@ -28,7 +28,7 @@ classifiers = [ | |||
| dependencies = [ | |||
| "boto3>=1.26.0,<2.0.0", | |||
| "botocore>=1.29.0,<2.0.0", | |||
| "docstring_parser>=0.15,<0.16.0", | |||
| "docstring_parser>=0.15,<0.17.0", | |||
There was a problem hiding this comment.
Hi thanks for this and our apologies for the strict pinning, would you mind increasing upper bound to 1.0, though. The intent here was that we wanted to prevent unexpected behavior because of major version bumps. But a max of 0.16 seems like it was simply a bug and I want to avoid another commit in the future when docstring_parser reaches 0.18
|
Closing this PR in favor of #239 as contributors do not have edit access. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The project is 'incompatible' with those that use docstring_parser>0.16 : docstring_parser is effectively pinned at 0.15 (2022-09-05), this change allows latest 0.16 (2024-03-15) which has "general support for Python 3.12".
Related Issues
none
Documentation PR
n/a
Type of Change
[Choose one of the above types of changes]
Testing
I've run the following:
hatch fmt --linterhatch fmt --formatterhatch test --allChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.