Skip to content

test: set OTEL_ env vars correctly for tests #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

awsarron
Copy link
Member

@awsarron awsarron commented Jun 3, 2025

Description

Fixes scenario where tests fail when OTEL_ environment variables are set in the environment where tests are ran.

Related Issues

N/A

Documentation PR

N/A

Type of Change

  • Bug fix
  • Tests fix

Testing

  • hatch fmt
  • hatch run test-lint
  • hatch test
  • hatch run test-integ

Checklist

  • I have read the CONTRIBUTING document
  • I have added tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@awsarron awsarron requested a review from a team as a code owner June 3, 2025 13:56
@awsarron awsarron merged commit da55dc8 into strands-agents:main Jun 3, 2025
20 checks passed
@awsarron awsarron deleted the tests-otel-env-vars branch June 3, 2025 15:04
jer96 pushed a commit to lukehau/sdk-python that referenced this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants