-
Notifications
You must be signed in to change notification settings - Fork 183
models - correct tool result content #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pgrayy
merged 6 commits into
strands-agents:main
from
pgrayy:models-recurse-tool-results
Jun 2, 2025
Merged
models - correct tool result content #154
pgrayy
merged 6 commits into
strands-agents:main
from
pgrayy:models-recurse-tool-results
Jun 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgrayy
commented
May 30, 2025
Unshure
reviewed
May 30, 2025
Unshure
previously approved these changes
Jun 2, 2025
…nto models-recurse-tool-results
Unshure
approved these changes
Jun 2, 2025
jer96
pushed a commit
to lukehau/sdk-python
that referenced
this pull request
Jun 3, 2025
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the OpenAI, LiteLLM, LlamaAPI, and Ollama model providers, we are
json.dump
'ing the tool result contents. This PR updates the formatting to more closely match the allowed specifications. This should improve the quality of responses and also help to avoid the confusing json dump errors that are raised when results contain binary data.Type of Change
Testing
hatch fmt --linter
hatch fmt --formatter
hatch test --all
hatch run test-lint
python test_models.py
: Ran the following script with each model:Everything is working as expected.
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.