-
Notifications
You must be signed in to change notification settings - Fork 372
Update firebase-react-native.md #6261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changing the link, The old link refers back to our old React Native Library which is no longer supported. I've changed some wording around as well to make sure customers know that installing the google services is needed.
...s/sources/catalog/libraries/mobile/react-native/destination-plugins/firebase-react-native.md
Outdated
Show resolved
Hide resolved
Changed to recommend links from Niall
Hi @niallzato Just changed to recommended links. |
...s/sources/catalog/libraries/mobile/react-native/destination-plugins/firebase-react-native.md
Outdated
Show resolved
Hide resolved
…destination-plugins/firebase-react-native.md
@@ -24,8 +24,8 @@ Run `pod install` after the installation to autolink the Firebase SDK. | |||
|
|||
See [React Native Firebase](https://rnfirebase.io) and [React Native Firebase Analytics](https://rnfirebase.io/analytics/usage) for more details of Firebase packages. | |||
|
|||
> info "rnfirebase dependency" | |||
> You will need to follow the [install guide](/docs/connections/sources/catalog/libraries/mobile/react-native/classic) for the rnfirebase dependency too. This may include adding the `GoogleService-Info.plist` and the `google-services.json` file. | |||
> info "Installation" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> info "Installation" | |
> info "Firebase dependencies" |
> info "rnfirebase dependency" | ||
> You will need to follow the [install guide](/docs/connections/sources/catalog/libraries/mobile/react-native/classic) for the rnfirebase dependency too. This may include adding the `GoogleService-Info.plist` and the `google-services.json` file. | ||
> info "Installation" | ||
> You will need to follow the install guide for [Android](https://rnfirebase.io/analytics/usage/installation/android){:target="_blank”} and/or [iOS](https://rnfirebase.io/analytics/usage/installation/ios){:target="_blank”}. This includes adding the `GoogleService-Info.plist` and the `google-services.json` file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> You will need to follow the install guide for [Android](https://rnfirebase.io/analytics/usage/installation/android){:target="_blank”} and/or [iOS](https://rnfirebase.io/analytics/usage/installation/ios){:target="_blank”}. This includes adding the `GoogleService-Info.plist` and the `google-services.json` file. | |
> To add the dependencies necessary for Segment's Firebase plugin, you'll need to add the `GoogleService-Info.plist` and the `google-services.json` files to your implementation. For more information, follow the instructions in the [Android](https://rnfirebase.io/analytics/usage/installation/android){:target="_blank”} and/or [iOS](https://rnfirebase.io/analytics/usage/installation/ios){:target="_blank”} documentation. |
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Proposed changes
Changing the link, The old link refers back to our old React Native Library, which is no longer supported. I've changed some wording around as well to make sure customers know that installing the Google services is needed.
Merge timing