Add vector quantization example to KBinsDiscretizer docs #31613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…drastically increase in size using this algorithm, shown by the example plot_face_Compress
There was a problem hiding this comment.
That's a valuable addition, thanks a lot @pw42020!
I only have a little suggestion to improve wording.
Comment on lines
+186
to
+187
| This can drastically increase the memory usage of the array. See the example on | ||
| :ref:`sphx_glr_auto_examples_cluster_plot_face_compress.py` |
There was a problem hiding this comment.
Suggested change
| This can drastically increase the memory usage of the array. See the example on | |
| :ref:`sphx_glr_auto_examples_cluster_plot_face_compress.py` | |
| This can drastically increase the memory usage of the array. See the | |
| :ref:`sphx_glr_auto_examples_cluster_plot_face_compress.py` |
Otherwise it gets rendered as "See the example on Vector Quantization Example ....", which reads a bit redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add vector quantization example to KBinsDiscretizer docs
Reference Issues/PRs
#30621 regarding
examples/cluster/plot_face_compress.pyWhat does this implement/fix? Explain your changes.
Adds additional documentation to the KBinsDiscretizer document in the form of an important note that it only outputs floats. This is shown to be an important use case in the Vector Quantization example where the size of the image is increased by 8x due to the transition from int8 (0-255) to float64.
Any other comments?
No.