-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TwitterShareButton url prop not working properly #97
Comments
@lucianourgal on version 4.0.4? |
To avoid re-rendering it was never added even in the previous version (https://github.com/saurabhnemade/react-twitter-embed/blob/example-updated/src/components/TwitterShareButton.js). However if you are still trying to achieve this, you can try like following by adding key: https://codesandbox.io/s/jolly-wood-is0zk?file=/src/TwiterTweet.js |
Thanks for replying @saurabhnemade . I'm actually using v4.0.6. |
Hi all,
I've run into two issues with the TwitterShareButton:
Condition:
Expected behavior:
Found behavior:
Condition:
Expected behavior:
Found behavior:
Code as follows:
`
import React from "react";
import {TwitterShareButton} from "react-twitter-embed";
import s from "./twitterTweet.scss";
const TwiterTweet: React.FC = ({
text,
url,
author,
buttonSize = "large"
}) => {
return (
<TwitterShareButton
url={url}
options={{
text: text,
via: author,
size: buttonSize
}}
placeholder="Loading"
/>
);
};
export default TwiterTweet;
`
The text was updated successfully, but these errors were encountered: