Skip to content

Update octocrab to latest version #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025

Conversation

nicholasbishop
Copy link
Member

I also included a change to sort the output of the program, to make it consistent between runs. This made it easier to verify that the octocrab update didn't change the output of the program.

This ensures the output order is consistent between runs, which makes it
easier to verify code changes are acting as intended.
The feature list has changed significantly since 0.18.1. Rustls is now
the default, and the builder code does not compile without additional
features, so switch to the default feature list.

This implicitly removes a dependency on an old version of ring.
@nicholasbishop nicholasbishop requested a review from phil-opp June 20, 2025 18:02
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@phil-opp phil-opp merged commit 2c9d34c into rust-osdev:main Jun 20, 2025
3 of 4 checks passed
@nicholasbishop nicholasbishop deleted the bishop-sorted branch June 20, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants