Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples may need to be updated after #140 #153

Closed
Zerpet opened this issue Jan 17, 2023 · 0 comments · Fixed by #207
Closed

Examples may need to be updated after #140 #153

Zerpet opened this issue Jan 17, 2023 · 0 comments · Fixed by #207
Assignees

Comments

@Zerpet
Copy link
Contributor

Zerpet commented Jan 17, 2023

Also probably examples need to be updated as they may imply some logic that is not really true anymore since context on publish is ignored.
Ex: https://github.com/rabbitmq/amqp091-go/blob/main/_examples/simple-producer/producer.go#L104-L111

Originally posted by @sapk in #140 (comment)

Filing this issue to track updating examples after the changes to DeferredConfirm

@Zerpet Zerpet self-assigned this Jun 21, 2023
@Zerpet Zerpet linked a pull request Jun 22, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant