Skip to content

Additional exception fields #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 5, 2020
Merged

Conversation

mistotebe
Copy link
Contributor

Work to improve how we raise exceptions on result, deals with controls and msgid being missing (#177, #208).

Ready for merging (pending #282, #283, #284 have been accepted) apart from last commit which is mainly here for initial review and can be split into its own PR if you want.

@somay
Copy link

somay commented May 26, 2019

LGTM regarding #208 .
My patch is already merged well.

@mistotebe
Copy link
Contributor Author

@tiran, @encukou any thoughts on this and the dependent PRs?

@encukou
Copy link
Member

encukou commented Jan 29, 2020

This is out of my depth.
@tiran, do you want to review this?

@mistotebe mistotebe marked this pull request as ready for review April 9, 2020 08:18
@mistotebe
Copy link
Contributor Author

Any ideas on a review? Without this it's impossible to have more than one operation pending on a connection.

@encukou
Copy link
Member

encukou commented Apr 29, 2020

My review will be sub-par, but it looks like I'll need to do it to move this forward. I'll dedicate a day next week to python-ldap.

@mistotebe
Copy link
Contributor Author

Thanks, I'll rebase it in the meantime.

@mistotebe mistotebe force-pushed the exceptions branch 4 times, most recently from 82f050b to 8492b16 Compare April 30, 2020 11:34
@mistotebe
Copy link
Contributor Author

Only fails on the same doctest as master now.

@encukou
Copy link
Member

encukou commented May 6, 2020

The last commit should go into a separate PR:

@mistotebe
Copy link
Contributor Author

I've moved the WIP commit into its own branch, but kept the .errnum one in for now. Let me know if it should be moved too.

Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thank you for the change, and apologies for the delay in reviewing.

@encukou encukou merged commit 3c0f7ef into python-ldap:master Jun 5, 2020
@tiran tiran added this to the 3.3 milestone Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants